Skip to content

Fix strchr() and related functions for ISO C23 compliance#3570

Open
purofle wants to merge 78 commits into
warmcat:mainfrom
purofle:fix-build-glibc
Open

Fix strchr() and related functions for ISO C23 compliance#3570
purofle wants to merge 78 commits into
warmcat:mainfrom
purofle:fix-build-glibc

Conversation

@purofle
Copy link
Copy Markdown
Contributor

@purofle purofle commented Apr 9, 2026

Since glibc-2.43:

For ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers into their input arrays now have definitions as macros that return a pointer to a const-qualified type when the input argument is a pointer to a const-qualified type.

The compilation test passed on my Glibc 2.43 system.

lws-team and others added 15 commits April 7, 2026 15:27
Since glibc-2.43:

For ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr,
strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers
into their input arrays now have definitions as macros that return a
pointer to a const-qualified type when the input argument is a pointer
to a const-qualified type.

Signed-off-by: purofle <yuguo.or@isrc.iscas.ac.cn>
Includes ${EXTIP4} and ${EXTIP6} for signing server's external IPs.

${DANE0} and ${DANE1} interpret the dane definition that's ongoing and look
for the matching tls certificate to produce the hash
These are from 16 old Coverity hits that I dismissed in my Coverity UI...
of course any other coverity user testing it doesn't get to know my
assessment.

So these are an attempt to silence these false positives by either
commenting the code as OK for Coverity to read, or modifying it to avoid
whatever it thought was happening the other way.
This simpifies enabling build of the -camshow example by LWS_WITH_WEBRTC
@lws-team lws-team force-pushed the main branch 11 times, most recently from 81c372a to 4a63b93 Compare May 5, 2026 14:25
@lws-team lws-team force-pushed the main branch 19 times, most recently from c0616c1 to d15a153 Compare May 14, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants